[tor-bugs] #5519 [Vidalia]: Some improvements for torcontrol code (ControlConnection, ControlSocket classes)

[Tor Bug Tracker & Wiki]

#5519: Some improvements for torcontrol code (ControlConnection, ControlSocket
classes)
---------------------+------------------------------------------------------
 Reporter:  sebb     |          Owner:  sebb                
     Type:  task     |         Status:  needs_revision      
 Priority:  minor    |      Milestone:                      
Component:  Vidalia  |        Version:  Vidalia: 0.3.1-alpha
 Keywords:           |         Parent:                      
   Points:           |   Actualpoints:                      
---------------------+------------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 I like the improvements, although you should separate them in two
 different commits and changes file. One of them is the infinite loop, and
 the other one is a cleanup.

 On a different note, have you experienced a bug where Vidalia issues a
 GETCONF ORPort before being authenticated? That's a check that is never
 done in these classes. I'm trying to catch that bug inside the code and
 come up with a fix, I wanted to let you know so you keep your eye up for
 this case.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5519#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online