[tor-bugs] #5863 [Torbutton]: Remove the ability to toggle Torbutton

[Tor Bug Tracker & Wiki]

#5863: Remove the ability to toggle Torbutton
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:  mikeperry
     Type:  enhancement      |         Status:  new      
 Priority:  critical         |      Milestone:           
Component:  Torbutton        |        Version:           
 Keywords:  MikePerry201205  |         Parent:           
   Points:                   |   Actualpoints:           
-----------------------------+----------------------------------------------
Changes (by proper):

 * cc: proper@… (added)


Comment:

 I vote for completely removing the toggle functionality.

 You could simplify and shrink the code.

 No more testing required for tests in non-tor mode.

 Tor Button settings dialog would get gets smaller, easier to understand.

 It's also a design goal, that Tor Button also shall not reveal the fact,
 that you are a Tor user, while you are not using Tor (toogle to non-Tor).
 As there are [https://www.torproject.org/projects/torbrowser/design
 /#firefox-patches Firefox patches] during Tor mode, do you disable them
 during non-Tor mode and could them be used to detect, that someone is not
 a Tor user?

 You also could get ride of
 [https://www.torproject.org/torbutton/en/design/#ToggleModelBugs Toogle
 Model Bugs]. I think your time is better spend in fixing more important
 stuff than less important, unfinished features barely anyone uses.

 Who still uses the toggle function anyway? You may ask your users if they
 are adamant about keeping the feature.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5863#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online