[tor-bugs] #5262 [Stem]: Implement Safe Cookie in Stem

[Tor Bug Tracker & Wiki]

#5262: Implement Safe Cookie in Stem
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  gsathya     
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Stem         |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by neena):

  * status:  new => needs_review


Comment:

 Replying to [ticket:5262 atagar]:
 > 1. Distill his script to just what we need to perform the
 authentication.
 >
 Done. I'm a little concerned if I have inadvertently compromised on
 security somewhere.

 > 2. Implement safe cookie in the
 [https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/connection.py
 connection module]. This involves adding SAFE_COOKIE to the AuthMethod
 enum, adding a new 'authenticate_safe_cookie' function, and adding this to
 the 'authenticate' method.
 >
 Done, somewhat. I have to document it properly. I've used
 authenticate_cookie as a starting point for this.

 > 3. Write
 [https://gitweb.torproject.org/stem.git/blob/HEAD:/test/unit/connection/authentication.py
 integration tests] similar to the current auth cookie tests.
 >
 My first attempt at this was 'wrong'. I'm doing this right now.

 I was hoping to get my code reviewed once it was fully documented/tested.
 Don't want to wait any longer, so, my code is here:
   http://repo.or.cz/w/stem/neena.git/shortlog/refs/heads/safe-cookie

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5262#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online