[tor-bugs] #5859 [Tor Client]: Numerous small build issues on msvc

[Tor Bug Tracker & Wiki]

#5859: Numerous small build issues on msvc
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 aes.c doesn't build because the openssl headers freak out if you don't
 include winsock2 right first.

 buffers.c uses "inline", when we only have the right magic to make
 "INLINE" work.

 MSVC doesn't accept that tor_assert(0) can never return, and so complains
 about functions that should return values but don't.

 MSVC warns if you declare a function as having a "int foo" argument and
 then implement it with a "const int foo" argument, even though the latter
 "const" is not a part of the function's interface.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5859>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online