[tor-bugs] #5520 [Vidalia]: Test the new bootstrap procedure in Vidalia alpha

[Tor Bug Tracker & Wiki]

#5520: Test the new bootstrap procedure in Vidalia alpha
---------------------+------------------------------------------------------
 Reporter:  chiiph   |          Owner:  sebb          
     Type:  task     |         Status:  needs_review  
 Priority:  normal   |      Milestone:  Vidalia: 0.3.x
Component:  Vidalia  |        Version:                
 Keywords:           |         Parent:                
   Points:           |   Actualpoints:                
---------------------+------------------------------------------------------

Comment(by chiiph):

 You use QTestLib, but the tests don't get executed as part of the building
 procedure. Which is fine, but you asked if it was integrated correctly and
 the answer is "in terms of developing tests it can be integrated even
 more, but if it tests things correctly I don't have a problem with
 executing another application after I rebuild Vidalia".

 Regarding the execution graph, one that I can remember was the Circuit
 Established phase, which can be called twice if the signal is emitted just
 before a certain method was called where circuitEstablished() was invoked.

 The other issue I didn't like is that there are a lot of possible signals
 emitted from TorControl at any given point, and from the MainWindow it's
 kind of hard to debug certain issues because you don't have a clear idea
 which methods where executed when. The graph isn't clear from the code,
 and that was one of my goals when rewriting that part.

 That doesn't mean my solution doesn't have problems, the idea with this
 task was to change the "it looks like it works" to "I'm 99% certain it
 works, because I have tools to test every possible scenario I can think
 of". So if your solution falls in the second sentence, then it's good for
 me. If you don't know, you need to look at the execution graph and make
 sure your tests have all that covered.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5520#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online