[tor-bugs] #5828 [Tor Directory Authority]: Something is super-inefficient in router_get_extrainfo_hash()

[Tor Bug Tracker & Wiki]

#5828: Something is super-inefficient in router_get_extrainfo_hash()
-------------------------------------+--------------------------------------
 Reporter:  arma                     |          Owner:                    
     Type:  defect                   |         Status:  new               
 Priority:  normal                   |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------

Comment(by arma):

 Here it is without those sissy optimizations:
 {{{
 #0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:40
 #1  0x00000000004592dc in router_get_extrainfo_hash (
     s=0x7f4314e9ad57 "extra-info winters
 810962DC3C058C757070420E9A9497532BB8185A\npublished 2012-05-09 23:40:20
 \nwrite-history 2012-05-09 23:27:30 (900 s)
 25795584,41270272,50443264,54130688,27383808,35012608,15630336,39361"...,
     digest=0x7fff7eb36c60 "þ5Jc¯\036\064\034±}l¼\233\016\001)¾#æ´")
     at routerparse.c:690
 #2  0x000000000045c9f0 in extrainfo_parse_entry_from_string (
     s=0x7f4314e9ad57 "extra-info winters
 810962DC3C058C757070420E9A9497532BB8185A\npublished 2012-05-09 23:40:20
 \nwrite-history 2012-05-09 23:27:30 (900 s)
 25795584,41270272,50443264,54130688,27383808,35012608,15630336,39361"...,
     end=0x7f4314e9bf79 "extra-info Unnamed
 43908858A50434F3CDAEC3EA1398E4C5E41223BB\npublished 2012-05-09 23:40:27
 \nwrite-history 2012-05-09 23:39:48 (900 s) 1333248\nread-history
 2012-05-09 23:39:48 (900 s) 4159488\nrouter-sign"...,
     cache_copy=0, routermap=0x14978c0) at routerparse.c:1646
 #3  0x000000000045ad19 in router_parse_list_from_string (s=0x7fff7eb36e28,
     eos=0x7f4315d98d04 "", dest=0x3289450, saved_location=SAVED_IN_CACHE,
     want_extrainfo=1, allow_annotations=0, prepend_annotations=0x0)
     at routerparse.c:1199
 #4  0x00000000004538c9 in router_load_extrainfo_from_string (
     s=0x7f4314e9ad57 "extra-info winters
 810962DC3C058C757070420E9A9497532BB8185A\npublished 2012-05-09 23:40:20
 \nwrite-history 2012-05-09 23:27:30 (900 s)
 25795584,41270272,50443264,54130688,27383808,35012608,15630336,39361"...,
     eos=0x7f4315d98d04 "", saved_location=SAVED_IN_CACHE,
     requested_fingerprints=0x0, descriptor_digests=0) at routerlist.c:3948
 #5  0x000000000044aa7b in router_reload_router_list_impl (store=0x14a5610)
     at routerlist.c:847
 #6  0x000000000044ad33 in router_reload_router_list () at routerlist.c:903
 #7  0x000000000040cb7c in do_main_loop () at main.c:1864
 #8  0x000000000040e348 in tor_main (argc=3, argv=0x7fff7eb37168) at
 main.c:2619
 #9  0x0000000000408b84 in main (argc=3, argv=0x7fff7eb37168) at
 tor_main.c:30
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5828#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online