[tor-bugs] #5761 [TorBrowserButton]: Decide if it's safe to pass the Dooble around the Tor Community

[Tor Bug Tracker & Wiki]

#5761: Decide if it's safe to pass the Dooble around the Tor Community
---------------------------------+------------------------------------------
    Reporter:  mike123           |       Owner:  mike123
        Type:  enhancement       |      Status:  closed 
    Priority:  normal            |   Milestone:         
   Component:  TorBrowserButton  |     Version:         
  Resolution:  invalid           |    Keywords:         
      Parent:                    |      Points:         
Actualpoints:                    |  
---------------------------------+------------------------------------------

Comment(by textbrowser):

 Thanks.

 The vector is removed.

 gcry_error_t dmisc::setInitializationVector(QByteArray &bytes)
 {
   size_t ivLength = 0;
   gcry_error_t err = 0;

   if((ivLength = gcry_cipher_get_algo_blklen(s_algorithm)) != 0)
     {
       char *iv = (char *) gcry_calloc_secure(ivLength, sizeof(char));

       if(iv)
         {
           if(bytes.isEmpty())
             {
               gcry_create_nonce((void *) iv, ivLength);
               bytes.append(iv, ivLength);
             }
           else
             {
               ivLength = qMin(ivLength, static_cast<size_t>
 (bytes.size()));
               memcpy((void *) iv,
                      (const void *) bytes.constData(),
                      ivLength);
               bytes.remove(0, ivLength);
             }

           err = gcry_cipher_setiv(s_cipherCtx, (const void *) iv,
 ivLength);
           gcry_free(iv);
         }
       else
         err = GPG_ERR_ENOMEM;
     }
   else
     err = GPG_ERR_INV_LENGTH;

   return err;
 }

 Dooble shadows Qt/WebKit with respect to image blocking. JavaScript may be
 blocked per site. I don't know if the disabling of it propagates to every
 frame of a page. Please experiment and provide a detailed report to
 Dooble. Your insight is important. Peachy.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5761#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online