[tor-bugs] #5786 [Tor Directory Authority]: A single authority can crash the other authorities

[Tor Bug Tracker & Wiki]

#5786: A single authority can crash the other authorities
-------------------------------------+--------------------------------------
 Reporter:  asn                      |          Owner:                    
     Type:  defect                   |         Status:  needs_review      
 Priority:  normal                   |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Branch bug5786_range_022 [*] fixes the behavior of tor_parse_long and its
 friends so that they can detect overflows on
 tor_parse_long(x,10,INT32_MIN,INT32_MAX,&ok,NULL) when sizeof(long) ==
 sizeof(int32_t).

 Branch bug5786 has the authority-size fixes: it detects bad authority
 arguments earlier in the bandwidth computation before an assertion would
 happen[**], and tries to detect duplicate entries in networkstatus
 parameter lines.  I'm currently targeting it at 0.2.3.x, but could
 possibly be persuaded that it's an 0.2.2.x item.

 My understanding is that boboper doesn't want me putting his name on any
 commits.  If that's wrong, I hope he'll say so.

 [*] all branches here are in my public repo.
 [**] This changes the previous behavior of the algorithm.  However, since
 the previous behavior was "assertion failure", I'm not too concerned.

 Adding mike to the cc in hopes he can review the bandwidth weight issues.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5786#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online