[tor-bugs] #5458 [Tor Client]: Clients should warn in the event of excessive circuit failures

[Tor Bug Tracker & Wiki]

#5458: Clients should warn in the event of excessive circuit failures
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:       
     Type:  defect           |         Status:  new  
 Priority:  major            |      Milestone:       
Component:  Tor Client       |        Version:       
 Keywords:  MikePerry201205  |         Parent:  #5456
   Points:  mikeperry        |   Actualpoints:       
-----------------------------+----------------------------------------------
Changes (by mikeperry):

 * cc: arma, nickm (added)


Comment:

 nickm+arma: I have a rough draft of a patch in mikeperry/bug5458, but I
 have quite a few questions. They are listed in the commit message and in
 the XXX's in the source, but here's a copy of my questions for easy reply
 on trac:

 1. The EntryGuard state file format and parsing code is extra strength
 crazy sauce. Have I modified it correctly?

 2. I think we should actually remove guards/bridges that exceed our
 warning threshold (there's an XXX where we should do this). The question
 is: how? Can I just remove them from the list? What about bridges? Will
 they just get added back? Can I remove them from the user's config, or is
 that too rude?

 3. Did I handle bridges correctly in the first place? I think I can treat
 them like guards in most cases in the code, but can I really?

 4. Do I need to do anything special for 4 hop circuits/cannibalized
 circuits?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5458#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online