[tor-bugs] #4296 [Tor Client]: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()

[Tor Bug Tracker & Wiki]

#4296: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by asn):

 Aha! I see that your `d6c18c5804f12f8f4428abce11fc47c64d2a0dd0` stopped
 `fclose()`ing the handles in `log_from_pipe()` for a good reason.

 I guess the new question is, who calls `tor_process_handle_destroy()` on
 the `child_handle`  created by the last `tor_check_port_forwarding()`
 call? I guess no one.

 Do we care about this? If not, I'm all about closing this stupid ticket.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4296#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online