[tor-bugs] #5537 [Tor Client]: client_check_address_changed() looks likely to do badly with ipv6 connections

[Tor Bug Tracker & Wiki]

#5537: client_check_address_changed() looks likely to do badly with ipv6
connections
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  ipv6        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 Clients call client_check_address_changed() on every outgoing connection.
 This function then does a getsockname() on the socket using a sockaddr_in,
 and logs a warnings if the getsockname() fails.

 Unless I'm missing something fundamental, this will spam users' logs with
 a bunch of EFAULT errors.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5537>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online