[tor-bugs] #5374 [Tor Relay]: getsockname() to check for address change failed

[Tor Bug Tracker & Wiki]

#5374: getsockname() to check for address change failed
-----------------------+----------------------------------------------------
 Reporter:  funkstar   |          Owner:                     
     Type:  defect     |         Status:  new                
 Priority:  major      |      Milestone:  Tor: 0.2.3.x-final 
Component:  Tor Relay  |        Version:  Tor: 0.2.3.12-alpha
 Keywords:             |         Parent:                     
   Points:             |   Actualpoints:                     
-----------------------+----------------------------------------------------

Comment(by nickm):

 So, the "attempt to automatically configure port forwarding" option is a
 Vidalia thing that turns on Vidalia's UPNP feature.

 I wonder if this could be an  IPv6 issue: the client_check_address_changed
 code is totally IPv4 specific.

 But the MSDN documentation for getsockname() says that a WSAEINVAL means,
 "The socket has not been bound to an address with bind, or ADDR_ANY is
 specified in bind but connection has not yet occurred."  So that doesn't
 sound like an IPv6 issue.  But looking at the code for the one function
 that calls client_check_address_changed(), it only calls it if the connect
 has happened.  So that's weird.  Maybe there's something crazy going on in
 windows, and it only wants to have getsockname() work once the connect()
 is finished?  That would be crazy. I'll try writing a little test program
 there, I guess.

 Opening another ticket for the IPv6 issue: conceivably it's related and
 the documentation is just wrong.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5374#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online