[tor-bugs] #5528 [Tor Client]: router->address is redundant with router->addr

[Tor Bug Tracker & Wiki]

#5528: router->address is redundant with router->addr
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by ln5):

 Corresponds well with my notes from the "private bridges on IPv6" work:

 - rewrite_node_address_for_bridge() <-- learned_bridge_descriptor() <--
 routerlist_descriptors_added()
 - router_rebuild_descriptor() using addr from
 router_pick_published_address() using
     - resolve_my_address() -- not IPv6 ready
     - router_guess_address_from_dir_headers() -- not IPv6 ready
   - So if we go for storing the IPv6 address this is a problem for
     clients if router_rebuild_descriptor() is ever called for bridges
     in bridge list, which it seems like it's not the case
 - router_parse_entry_from_string() uses arg[1] from a K_ROUTER
   ("router") descriptor, i.e. the IPv4 address
 - routerinfo_free -- freeing it

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5528#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online