[tor-bugs] #4438 [Tor Directory Authority]: Dirauth sometimes exits when SafeLogging is toggled

[Tor Bug Tracker & Wiki]

#4438: Dirauth sometimes exits when SafeLogging is toggled
-------------------------------------+--------------------------------------
 Reporter:  Sebastian                |          Owner:                    
     Type:  defect                   |         Status:  needs_review      
 Priority:  normal                   |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------

Comment(by nickm):

 I think that the fix in your bug4438 branch looks basically good to me,
 Sebastian.

 I think frosty_un's comment above (if I am reading it right) would be well
 addressed by tweaking the info-level log message to say that this isn't
 actually a problem, and switching the logic so that instead of checking
 for WRA_WAS_REJECTED(x), we check for x != WAS_NOT_NEW or
 !WRA_WAS_OUTDATED(x).  That'd bulletproof the logic against future
 changes to the enum , and bulletproof the message against user confusion.

 cypherpunks's comment is also a fine idea, but seems to be a different
 ticket from this one.  I've split it out into #5507.

 Please have a look at my branch bug4438  , based on Sebastian's?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4438#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online