[tor-bugs] #3940 [Tor Client]: Allow MapAddress .exit even if AllowDotExit is 0

[Tor Bug Tracker & Wiki]

#3940: Allow MapAddress .exit even if AllowDotExit is 0
------------------------+---------------------------------------------------
 Reporter:  sjmurdoch   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:  Tor: 0.2.2.32     
 Keywords:  regression  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Testing a little with a MapAddress to a .exit, I see that we hit this
 clause:
 {{{

       if (started_without_chosen_exit &&
           !strcasecmpend(socks->address, ".exit") &&
           map_expires < TIME_MAX)
         remapped_to_exit = 1;
 }}}

 Why isn't remapped_to_exit getting set?  Because map_expires == TIME_MAX.
 Why was this map_expires==TIME_MAX check here? Because remapped_to_exit
 was originally used to let us know that we were in a TrackExitHost
 situation, where we needed to set the chosen_exit_retries field.

 Probably fix in branch bug3940_022 in my public repository.

 Should there be an additional option that says "not even in MapAddress"?
 Maybe.

 Should there be more documentation that says that AllowDotExit 0 doesn't
 apply to TrackHostExits and MapAddress?  Yes, I think so.

 Other issues?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3940#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online