[tor-bugs] #5457 [Torflow]: Bw auths can't count circuit failures properly in compatibility mode

[Tor Bug Tracker & Wiki]

#5457: Bw auths can't count circuit failures properly in compatibility mode
-----------------------+----------------------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  new      
 Priority:  major      |      Milestone:           
Component:  Torflow    |        Version:           
 Keywords:             |         Parent:  #5456    
   Points:             |   Actualpoints:           
-----------------------+----------------------------------------------------
 When we are using descriptor bandwidth (ie no feedback), we are unable to
 properly use circuit failure statistics to penalize nodes that are either
 attempting path bias, or are just experiencing CPU overload.

 The fix *should* be simple. I think we just need to add another clause in
 aggregate.py where we check for use_circ_fails to also check for
 use_desc_bw and properly combine the pid_error and circ_error for that
 case (perhaps just by multiplying them).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5457>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online