[tor-bugs] #5146 [Tor Bridge]: Bridges include or-address [::]:$port in their server descriptor

[Tor Bug Tracker & Wiki]

#5146: Bridges include or-address [::]:$port in their server descriptor
------------------------+---------------------------------------------------
 Reporter:  karsten     |          Owner:  ln5                
     Type:  defect      |         Status:  assigned           
 Priority:  normal      |      Milestone:                     
Component:  Tor Bridge  |        Version:  Tor: 0.2.3.12-alpha
 Keywords:              |         Parent:  #4563              
   Points:              |   Actualpoints:                     
------------------------+---------------------------------------------------

Comment(by nickm):

 Replying to [comment:4 ln5]:
 > (Slipped on submit.)
 >
 > router_rebuild_descriptor() gets ri->ipv4h_addr from
 > router_pick_published_address() while ri->ipv6_orport comes from
 > configuration, non-sanitized.
 >
 > router_pick_published_address() first tries resolve_my_address() and
 > then, if that fails, tries to get it from HTTP headers received from
 > "a peer".
 >
 > Should we turn resolve_my_address() into resolve_my_addresses() and
 > teach it about IPv6?  get_interface_address6() used here needs some
 > work for #4806 too.

 That seems like a plausible solution.  Other options include looking at
 gethostname() of the listener socket, but resolving your address is
 probably the better bet.

 > As a minimal approach, we should check IPv6 ORPort's from config with
 > tor_addr_is_internal(for_listening=1).  This will catch '[::]'.  And
 > document the importance of configuring an IPv6 ORPort with some extra
 > care for the time being.

 Right.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5146#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online