[tor-bugs] #3894 [Tor Client]: Fix compilation on FreeBSD 4

[Tor Bug Tracker & Wiki]

#3894: Fix compilation on FreeBSD 4
---------------------------+------------------------------------------------
    Reporter:  nickm       |       Owner:                    
        Type:  defect      |      Status:  reopened          
    Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  Tor: 0.2.2.35     
  Resolution:              |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------
Changes (by grarpamp):

  * status:  closed => reopened
 * cc: grarpamp@… (added)
  * component:  Tor Relay => Tor Client
  * priority:  minor => normal
  * version:  Tor: 0.2.2.32 => Tor: 0.2.2.35
  * resolution:  fixed =>


Comment:

 Here's the next installment. I'm writing this via the working binary
 produced using the following components...

 FreeBSD RELENG_4 i386 gcc 2.95.4
 zlib 1.2.6
 openssl 0.9.8u
 libevent 1.4.14b
 tor 0.2.2.35
 the attached patch

 The older patchwork on this was lost, and the email exchange looked
 reasonable at the time, so I just accepted 0.2.2.35 as is and fixed
 the problems evident in it alone.

 The following warnings are all that remain on RELENG_4 if someone
 wants to address them before commit...

 Making all in or
 control.c: In function `handle_control_attachstream':
 control.c:2450: warning: `exit_digest' might be used uninitialized in this
 function
 routerparse.c: In function `router_parse_list_from_string':
 routerparse.c:1166: warning: `signed_desc' might be used uninitialized in
 this function

 Patch attached for everything else but the above.

 Regarding RELENG_8 with update to openssl 1.0.1 and libevent 2.0.18 ...
 The two warnings above do not exist (tested), the patch generates
 no additional warnings (tested), and the binary resulting from the
 patch is presumed to work as well (untested).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3894#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online