[tor-bugs] #5156 [Obfsproxy]: assertion failure at src/network.c:931: circ

[Tor Bug Tracker & Wiki]

#5156: assertion failure at src/network.c:931: circ
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn         
     Type:  defect     |         Status:  needs_review
 Priority:  major      |      Milestone:              
Component:  Obfsproxy  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by asn):

 Replying to [comment:17 nickm]:
 > I'm asking, if the idea is to set the callbacks _after_
 bufferevent_connect_hostname(), how do we detect and respond to an
 immediate failure in bufferevent_connect_hostname()?
 >

 Hm, I think the basic idea is to have a circuit already created when
 `bufferevent_connect_hostname()` is called. I don't see the idea of
 setting ''callbacks _after_ bufferevent_connect_hostname()'' in the code:
 https://gitorious.org/obfsproxy/obfsproxy/blobs/bug5156_take2/src/network.c#line649

 Specifically, the idea is to have '''nothing''' after
 `bufferevent_socket_connect_hostname()`, because of comment:8.

 Am I misunderstanding you?

 > Other than that, I'd say "test it and merge it!"  (Maybe ask roger to
 test it too: he seems to be pretty good at reproducing the original bug.)

 I tested it. The bug is indeed quite easily reproducible, just kill your
 network interface, fire up `obfsproxy obfs2 socks 127.0.0.1:5555` and
 point a socks client to it (say have `ClientTransportPlugin obfs2 socks4
 127.0.0.1:5555` and `Bridge obfs2 8.8.8.8:1051` in your torrc.)

 Still, it would be great if Roger tested it too, before merging.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5156#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online