[tor-bugs] #5156 [Obfsproxy]: assertion failure at src/network.c:931: circ

[Tor Bug Tracker & Wiki]

#5156: assertion failure at src/network.c:931: circ
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn         
     Type:  defect     |         Status:  needs_review
 Priority:  major      |      Milestone:              
Component:  Obfsproxy  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by asn):

 Replying to [comment:15 nickm]:
 > The strategy looks sound; it's worth trying out.
 >
 > Only...what frees the bufferevent if it fails before the callbacks are
 set?

 Hm, which case are you thinking of?

 Generally, `create_other_side_of_conn()` should create the bufferevent and
 attach it to the `newconn` `conn_t`. This means that `conn_free()` will
 also free the bufferevent.

 Then, after `circuit_create()` is called, `newconn` and `conn` are bound
 in a circuit, which means that `conn_free`ing one is also freeing the
 other.

 Which case did I miss?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5156#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online