[tor-bugs] #5434 [Tor Client]: tor-0.2.3.12_alpha: ./configure --enable-upnp fails when using miniupnpc-1.6

[Tor Bug Tracker & Wiki]

#5434: tor-0.2.3.12_alpha: ./configure --enable-upnp fails when using
miniupnpc-1.6
------------------------+---------------------------------------------------
 Reporter:  blueness    |          Owner:                     
     Type:  defect      |         Status:  new                
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final 
Component:  Tor Client  |        Version:  Tor: 0.2.3.12-alpha
 Keywords:              |         Parent:                     
   Points:              |   Actualpoints:                     
------------------------+---------------------------------------------------
 There is a change in miniupnpc from 1.5 to 1.6 causing tor-0.2.3.12_alpha
 to fail to configure with --enable-upnp.  The definition of upnpDiscover()
 prototyped in <miniupnpc/miniupnpc.h> changed from

 LIBSPEC struct UPNPDev *
 upnpDiscover(int delay, const char * multicastif, const char *
 minissdpdsock, int sameport);

 to

 LIBSPEC struct UPNPDev *
 upnpDiscover(int delay, const char * multicastif, const char *
 minissdpdsock, int sameport, int ipv6, int * error);

 This causes the test program generated by ./configure to fail since it
 tries to call upnpDiscover(1, 0, 0, 0 );  That's an easy fix, but more
 involved is the only call made to upnpDiscover which is in src/tools/tor-
 fw-helper/tor-fw-helper-upnp.c.  ipv6 should be disabled, but should int *
 error be handled?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5434>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online