[tor-bugs] #5364 [Vidalia]: less redundancy for Browser Bundle Settings under Plugins

[Tor Bug Tracker & Wiki]

#5364: less redundancy for Browser Bundle Settings under Plugins
-----------------------------+----------------------------------------------
 Reporter:  sirop            |          Owner:  chiiph              
     Type:  defect           |         Status:  needs_information   
 Priority:  normal           |      Milestone:                      
Component:  Vidalia          |        Version:  Vidalia: 0.3.1-alpha
 Keywords:  vidalia plugins  |         Parent:                      
   Points:                   |   Actualpoints:                      
-----------------------------+----------------------------------------------
Changes (by sirop):

  * status:  accepted => needs_information


Comment:

 Replying to [comment:3 sirop]:
 > Replying to [comment:2 chiiph]:
 > > I think the easiest way for this would be to rename the label.
 > Yes, I also think, to rename the label would be quicker.
 launchBrowserFromDirectory: function() {
  189         vdebug("TBB at launchBrowserFromDirectory");
  190         var browserDirectoryFilename =
 this.tab.getSetting(this.BrowserExecutable, "");
  191         var browserDirectory =
 this.tab.getSetting(this.BrowserDirectory, "");
  192
  193         this.browserProcess.setEnvironment(this.updateBrowserEnv());
  194
  195         var browserExecutable =
 QDir.toNativeSeparators(browserDirectory + "/App/Firefox/" +
  196
 browserDirectoryFilename);
 //''' Well, browserDirectory is already Tor-browser/App/Firefox  or
 not?'''

  197
  198         var profileDir = QDir.toNativeSeparators(browserDirectory +
 "/Data/profile");
  199         var browserDirObj = new QDir(browserDirectory);
  200
  201         /* Copy the profile directory if it's not already there */
  202         if(!browserDirObj.exists("Data/profile")) {
  203             browserDirObj.mkpath("Data/profile");
  204             this.copy_dir(browserDirectory +
 "/App/DefaultData/profile", browserDirectory + "/Data/profile");
  205         }
 // '''As I see in tor-browser-2.2.35-7.2-dev, Data/profile is already
 there.'''
 // '''App/DefaultData/profile is not in tor-browser-2.2.35-7.2-dev .'''

  206
  207         /* Copy the plugins directory if it's not already there */
  208         if (!browserDirObj.exists("Data/plugins")) {
  209             browserDirObj.mkpath("Data/plugins");
  210             this.copy_dir(browserDirectory +
 "/App/DefaultData/plugins", browserDirectory + "/Data/plugins");
  211         }
 // '''As I see in tor-browser-2.2.35-7.2-dev , Data/plugins is already
 there.'''
  212
  213         /* Build the command line arguments */
  214         /* Is this better or worse than MOZ_NO_REMOTE? */
  215         var commandLine = "-no-remote ";
  216         commandLine += "-profile ";
  217         commandLine += profileDir;
  218
  219         /* Launch the browser */
  220         this.browserProcess.start(browserExecutable, commandLine);
  221         this.browserProcess.toForeground()
  222     },

 Should we let Tor Browser directory be tor-browser-directory and not tor-
 browser-directory/App/Firefox?
 Do we  really need to copy both Data/* directories?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5364#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online