[tor-bugs] #5210 [Tor Client]: Enable gcc and ld hardening by default in 0.2.3.x

[Tor Bug Tracker & Wiki]

#5210: Enable gcc and ld hardening by default in 0.2.3.x
------------------------+---------------------------------------------------
 Reporter:  ioerror     |          Owner:  ioerror           
     Type:  defect      |         Status:  needs_revision    
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  security    |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nextgens):

 * cc: nextgens@… (added)


Comment:

 This is the working version of the above:
 https://github.com/nextgens/Tor/commit/62f3121a3d209fb4f826988d53b1aac93842502c

 now both --enable and --disable should now work as intended.

 There's two caveats with this patch still:
   - it doesn't detect whether gcc is in use and assumes that the compiler
 will ignore the flags it doesn't 'support'
   - it checks for the presence of the header 'elf.h' rather than the
 format of the executable produced (ie: the auto-detection magic won't work
 if you cross-compile or happen to have the elf headers installed)

 Detecting whether a particular flag is supported by the compiler could be
 done with a macro such as:
 http://ac-archive.sourceforge.net/ac-archive/ax_cflags_gcc_option.html

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5210#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online