[tor-bugs] #4488 [Tor Relay]: Track down the N23 patch, then update it for modern Tor

[Tor Bug Tracker & Wiki]

#4488: Track down the N23 patch, then update it for modern Tor
-------------------------------------+--------------------------------------
 Reporter:  arma                     |          Owner:                  
     Type:  task                     |         Status:  new             
 Priority:  normal                   |      Milestone:  Tor: unspecified
Component:  Tor Relay                |        Version:                  
 Keywords:  performance flowcontrol  |         Parent:  #4506           
   Points:                           |   Actualpoints:                  
-------------------------------------+--------------------------------------

Comment(by kevin):

 The crash was a failed assertion at connection_or.c:1866, which
 corresponds to the tor_assert(conn) within
 connection_or_send_flowcontrol().

 This should be easy to fix: the caller should just ensure that conn is not
 null.

 Here is the code in question:

 {{{
 void
 connection_or_send_flowcontrol(circid_t circ_id, or_connection_t *conn,
 uint32_t cells_fwded)
 {
   cell_t cell;

   tor_assert(conn);

   memset(&cell, 0, sizeof(cell_t));
   cell.circ_id = circ_id;
   cell.command = CELL_FLOWCONTROL;
   set_uint32(cell.payload, htonl(cells_fwded));
   connection_or_write_cell_to_buf(&cell, conn);
 }
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4488#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online