[tor-bugs] #5346 [Tor Client]: parse_http_time is borked

[Tor Bug Tracker & Wiki]

#5346: parse_http_time is borked
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Review has turned up some other crazy things in our time parsing/handling.

 wanoskarnet has found some places where we allow tm_sec to be up to 61.
 That's wrong; 60 is the highest supported value.  We should grep for
 tm_sec to find all the cases of this.

 Sebastian notes that some of our checks are based on incorrectly assuming
 tm_mon ranges from 1 to 12, rather than the correct 0..11.  Further,
 tm_mday shouldn't be able to be 0 in a canonical date, but we seem to
 allow that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5346#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online