[tor-bugs] #4296 [Tor Client]: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()

[Tor Bug Tracker & Wiki]

#4296: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Hrm.  I still think 95df581 is good to merge, but for the others, we
 should indeed have the caller close stuff as appropriate.  Having a "read"
 function that sometimes closes the pipe doesn't make much sense.

 Should I cherrypick the one commit I like at this point?  Looking at
 log_from_pipe(), it looks like it doesn't fclose streams any more.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4296#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online