[tor-bugs] #5324 [Tor Relay]: connection_handle_read_impl() has wrong function comment?

[Tor Bug Tracker & Wiki]

#5324: connection_handle_read_impl() has wrong function comment?
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 Yes, I know this is what the code does now. But let's say I wanted to
 change Tor's behavior so it never "reads" past its read bucket size.
 (here, "reads" means getting the cells out of openssl's buffers into tor's
 buffers.) If I just delete all the code you quoted, I get this behavior.
 But I may have a new bug, which is that Tor never thinks to check if
 SSL_pending(conn->tls->ssl), because Tor assumed that we would never leave
 pending bytes pending. The question is: would I in fact have this new bug?
 Or does libevent consider SSL_pending() and trigger the callback if so?

 (If I would have the new bug, is it hard to make libevent trigger the
 callback when SSL_pending is true, or is this a rat's nest I would rather
 avoid?)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5324#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online