[tor-bugs] #6257 [Stem]: Bump to @type bridge-extra-info 1.1

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Sat Jun 30 15:59:26 UTC 2012


#6257: Bump to @type bridge-extra-info 1.1
---------------------+------------------------------------------------------
 Reporter:  karsten  |          Owner:  atagar           
     Type:  defect   |         Status:  needs_information
 Priority:  normal   |      Milestone:                   
Component:  Stem     |        Version:                   
 Keywords:           |         Parent:                   
   Points:           |   Actualpoints:                   
---------------------+------------------------------------------------------

Comment(by karsten):

 Replying to [comment:2 atagar]:
 > Change made...
 >
 https://gitweb.torproject.org/stem.git/commitdiff/c35c8a6cbb3659841f79159512c24a08a5e1d622

 In that commit, doesn't the following line only accept versions 1.0 and
 1.1?

 {{{
 +    elif desc_type == "bridge-extra-info" and major_version == 1 and
 minor_version in (0, 1):
 }}}

 Shouldn't stem also accept versions 1.2 and higher?  It won't necessarily
 understand the new keywords, but it should parse all the parts that it
 understands.

 > Though I'm not clear on this new field's attributes. Is it a simple
 only-appears-once string field? Is it a space separated listing? Does it
 appear multiple times to provide a list of values?

 See the new `transport` keyword in
 [https://gitweb.torproject.org/torspec.git/blob/HEAD:/dir-spec.txt#l890
 dir-spec.txt]:

 {{{
     "transport" transportname address:port [arglist] NL
         [Any number.]

         Signals that the router supports the 'transportname' pluggable
         transport in IP address 'address' and TCP port 'port'.
 }}}

 For sanitized bridge descriptors we scrub the part after `transportname`
 as explained in sanitizing step 5 on the
 [https://metrics.torproject.org/formats.html#bridgedesc formats page].
 `transportname` is a single string, but there can be any number of
 `transport` lines.

 Can I deploy the changed metrics-db code to produce 1.1 bridge extra-infos
 descriptors then?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6257#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list