[tor-bugs] #4195 [Tor Relay]: Stop using sscanf in rephist

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Jun 28 05:45:17 UTC 2012


#4195: Stop using sscanf in rephist
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by andrea):

 This mostly looks okay to me.  Two possible issues:

  * Should scan_signed() use scan_unsigned after it parses the '-' instead
 of duplicating that functionality?

  * Is scan_double() ever going to be used for user-supplied floating-point
 values?  Should we perhaps document somewhere that it doesn't parse things
 like '2.56E+02'?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4195#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list