[tor-bugs] #6226 [Tor Client]: pt unit tests do dns lookup on "abcd"

[Tor Bug Tracker & Wiki]

#6226: pt unit tests do dns lookup on "abcd"
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                  
     Type:  defect      |         Status:  needs_review    
 Priority:  normal      |      Milestone:  Tor: unspecified
Component:  Tor Client  |        Version:                  
 Keywords:              |         Parent:                  
   Points:              |   Actualpoints:                  
------------------------+---------------------------------------------------

Comment(by asn):

 Replying to [comment:3 nickm]:
 > It looks like this patch changes the behavior of the parse_*_line
 functions so they just parsing, with no lookup.  What will eventually do
 the lookup?
 >

 Hm, I'm confused. Why do you think that `parse_{c,s}method_line()` should
 do DNS lookups? Those functions are for parsing the `{C,S}METHOD` lines
 from the managed proxy, so that they know in which TCP ports its
 transports managed to bind (the addrport in the `{C,S}METHOD` line is
 later used in `connection_or_connect()` when using the transport proxy,
 IIRC).

 I'm not sure if there are any cases where a pluggable transport proxy
 would return a domain name in a `{C,S}METHOD`.

 > The changes file seems iffy; the change doesn't make it so we don't do
 the parsing when doing corrupted addresses: It makes it so we don't do the
 parsing in the parse_* functions at all.

 Hm, I'm confused again. We do the addrport parsing in
 `parse_{c,s}method_line()`, we just don't use a `*_lookup` function
 anymore.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6226#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online