[tor-bugs] #6167 [Tor Hidden Services]: Possible assertion failure in connection_ap_handshake_attach_circuit()

[Tor Bug Tracker & Wiki]

#6167: Possible assertion failure in connection_ap_handshake_attach_circuit()
---------------------------------+------------------------------------------
 Reporter:  nickm                |          Owner:                    
     Type:  defect               |         Status:  new               
 Priority:  major                |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 I couldn't figure out a way for this assertion failure to occur in Tor
 0.2.2.x or 0.2.3.x.  boboper couldn't figure out a way for it to occur in
 Tor, and found suspicious changes in ‘AdvOR’.

 The code having to do with `intro_going_on_but_too_old` in
 `circuit_get_best` seems bogus, but I don't see how it could cause this
 bug, and boboper thinks it's innocent here too.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6167#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online