[tor-bugs] #6028 [Tor Relay]: errno_to_orconn_end_reason() spams log when errno == 0

[Tor Bug Tracker & Wiki]

#6028: errno_to_orconn_end_reason() spams log when errno == 0
-----------------------+----------------------------------------------------
 Reporter:  ln5        |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by andrea):

 It looks like ln5 is right about the two possible ways to get out of
 connection_connect() returning -1 without setting *socket_error.  Ending
 up with END_OR_CONN_REASON_RESOURCE_LIMIT by setting ENOBUFS in the first
 case sounds reasonable; for the second, perhaps the same?  Bufferevents
 would only fail to be created because of memory shortage or something like
 that?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6028#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online