[tor-bugs] #6174 [Tor Client]: De-kludgify marking circs as unsuitable for new streams
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Fri Jun 15 23:15:02 UTC 2012
#6174: De-kludgify marking circs as unsuitable for new streams
------------------------+---------------------------------------------------
Reporter: rransom | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
{{{
/* XXXX024 This is a screwed-up way to say "This is too dirty
* for new circuits. */
circ->timestamp_dirty -= options->MaxCircuitDirtiness;
}}}
{{{
/* XXXX024 this is a kludgy way to do this. */
tor_assert(circ->timestamp_dirty);
circ->timestamp_dirty -= options->MaxCircuitDirtiness;
}}}
{{{
/* XXXX024 this is a kludgy way to do this. */
tor_assert(circ->_base.timestamp_dirty);
circ->_base.timestamp_dirty -= get_options()->MaxCircuitDirtiness;
}}}
Yes, it is, and wrong in several different ways too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6174>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list