[tor-bugs] #5458 [Tor Client]: Clients should warn and disable guards responsible for excessive circuit failures

[Tor Bug Tracker & Wiki]

#5458: Clients should warn and disable guards responsible for excessive circuit
failures
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:  mikeperry         
     Type:  defect           |         Status:  needs_revision    
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:                    
 Keywords:  MikePerry201206  |         Parent:  #5456             
   Points:  6                |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by nickm):

 {{{
 +  if ((guard->first_hops % (unsigned)pathbias_get_min_circs(options)) ==
 0) {
 +      entry_guards_changed();
 +  }
 }}}

 That's a kludge, and I think it might be a needless one.  We can just say
 entry_guards_changed(), and that will cause a state write to happen in 10
 minutes or an hour, depending.  Am I wrong?

 Using "0" for the "never disable circuits" value seems a little worrisome
 to me; it relies on us using < rather than <= for when we compare the
 actual failure rate to the threshold.   Should I worry?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5458#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online