[tor-bugs] #5394 [Tor Client]: warn users about their clock if they see a consensus from the future

[Tor Bug Tracker & Wiki]

#5394: warn users about their clock if they see a consensus from the future
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 I think we already do this.  Check out networkstatus.c around line 1861 in
 networkstatus_set_current_consensus:
 {{{
 #define EARLY_CONSENSUS_NOTICE_SKEW 60

   if (now < c->valid_after - EARLY_CONSENSUS_NOTICE_SKEW) {
     char tbuf[ISO_TIME_LEN+1];
     char dbuf[64];
     long delta = now - c->valid_after;
     format_iso_time(tbuf, c->valid_after);
     format_time_interval(dbuf, sizeof(dbuf), delta);
     log_warn(LD_GENERAL, "Our clock is %s behind the time published in the
 "
              "consensus network status document (%s GMT).  Tor needs an "
              "accurate clock to work correctly. Please check your time and
 "
              "date settings!", dbuf, tbuf);
     control_event_general_status(LOG_WARN,
                     "CLOCK_SKEW MIN_SKEW=%ld SOURCE=CONSENSUS", delta);
 }}}

 That sure looks like the kind of thing you wanted.  It looks like we've
 been doing it since 7709fb71 back in 2007.  Close as worksforme?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5394#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online