[tor-bugs] #5969 [Tor Client]: A couple of compile warnings with clang 3.1

[Tor Bug Tracker & Wiki]

#5969: A couple of compile warnings with clang 3.1
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:                    
        Type:  defect      |      Status:  reopened          
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:                    
  Resolution:              |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------
Changes (by arma):

  * priority:  normal => major


Comment:

 Commit 3a9351b57e52 includes

 {{{
 -  if (tor_snprintf(format_buf, sizeof(format_buf), "650 %s %s %s\r\n",
 -                   status, sev, format)<0) {
 +  if (tor_snprintf(format_buf, sizeof(format_buf), "650 %s %s\r\n",
 +                   status, sev)<0) {
 [...]
 +  tor_vasprintf(&user_buf, format, args);
 }}}

 Before, 'format' was before the \r\n. After, it is after.

 This causes Tor to output malformed control events, make Vidalia freak out
 and freeze.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5969#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online