[tor-bugs] #6028 [Tor Relay]: errno_to_orconn_end_reason() spams log when errno == 0

[Tor Bug Tracker & Wiki]

#6028: errno_to_orconn_end_reason() spams log when errno == 0
-----------------------+----------------------------------------------------
 Reporter:  ln5        |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by ln5):

 I think it's circuit_extend() calling connection_or_connect() which
 then gets -1 from connection_connect().

 There are two obious ways out of there with return code -1 and no
 attempt to set *socket_error -- too many open connections and when XXX
 fails creating a bufferevent.  Judging from other log lines I'm
 suffering from the first.  Ending up with
 END_OR_CONN_REASON_RESOURCE_LIMIT might be the right thing in this
 case.  Should we *socket_error=ENOBUFS in connection_connect() after
 the warn_too_many_conns() call?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6028#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online