[tor-bugs] #6455 [Tor Client]: #6274 introduced minor memleak

[Tor Bug Tracker & Wiki]

#6455: #6274 introduced minor memleak
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  pt          |         Parent:  #6274             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 #6274 introduced this code in `src/or/config.c`:

 {{{
   if (options->ServerTransportPlugin && !server_mode(options)) {
     log_notice(LD_GENERAL, "Tor is not configured as a relay but you
 specified"
                " a ServerTransportPlugin line (%s). The
 ServerTransportPlugin "
                "line will be ignored.",
                esc_for_log(options->ServerTransportPlugin->value));
   }
 }}}

 This is wrong use of `esc_for_log()` and results in a memleak.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6455>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online