[tor-bugs] #6177 [Tor Relay]: Refactor rend_service_introduce()

[Tor Bug Tracker & Wiki]

#6177: Refactor rend_service_introduce()
-----------------------+----------------------------------------------------
 Reporter:  andrea     |          Owner:                    
     Type:  task       |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:  #6313             
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Replying to [comment:18 andrea]:
 > First successful connections using new INTRODUCE2 parser.  There's still
 some room to reorganize and clean up rend_service_introduce() later on in
 the circuit-building code, though.
 >
 > Is there any not-too-painful way to send older (pre-V3) cells to test
 those parts of the parser?

 From what I can tell, we have supported v3 since 0.2.1, whereas the oldest
 supported Tor version is 0.2.2.  So maybe (after confirming that) we
 should drop support for all the older introduce cell formats.  I've added
 #6418 on that one.

 The "easiest" ways I can think of to test these parts of the parser would
 be:
    * Add a unit test where you manually generate the cells, or use a
 canned value.
 or
    * Hack up rend_client_send_introduction locally so that it can never
 detect that the v3 protocol is supported; try it out with a test hidden
 service.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6177#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online