[tor-bugs] #6274 [Tor Client]: config parsing does not abort if ServerTransportPlugin but no ORPort

[Tor Bug Tracker & Wiki]

#6274: config parsing does not abort if ServerTransportPlugin but no ORPort
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  pt          |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  needs_review => needs_revision


Comment:

 Replying to [comment:4 nickm]:
 > Looks mostly good.  What happens in the case where the user has some
 ServerTransportPlugin options set, and then they turn ORPort off?  We
 probably want to disable the ServerTransportPlugins in that case too,
 right?
 >

 I suspect we are getting this for free with the
 `pt_prepare_proxy_list_for_config_read()` -> `sweep_proxy_list()` SIGHUP
 code.

 Since we are now only parsing `ServerTransportPlugin` lines `if
 (ServerTransportPlugin && server_mode())`, without an ORPort the proxies
 will still be marked for removal after the parsing loop, and the
 proxies/transports will be terminated/disabled.

 > Should we be looking at server_mode(options) rather than
 options->ORPort?

 Yes, I think so.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6274#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online