[tor-bugs] #4711 [Vidalia]: Vidalia Proxy settings partly loss after toggle.

[Tor Bug Tracker & Wiki]

#4711: Vidalia Proxy settings partly loss after toggle.
----------------------+-----------------------------------------------------
 Reporter:  bogo      |          Owner:  karulis        
     Type:  defect    |         Status:  needs_revision 
 Priority:  normal    |      Milestone:  Vidalia: 0.3.x 
Component:  Vidalia   |        Version:  Vidalia: 0.2.12
 Keywords:  settings  |         Parent:                 
   Points:            |   Actualpoints:                 
----------------------+-----------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 Even though it looks good, except for minor indentation issues, the alpha
 patch shouldn't set ProxyEnabled in vidalia.conf. The policy for settings
 handling in 0.3.2 and on is to have all tor settings live in the torrc
 (see setVolatileValue(), Torrc class, and related), which is problematic
 in a case like this one, because if you set the proxy you enable the use
 of it. One idea was to have a certain kind of torrc comment format, like
 for example, if a line looks like this:

 {{{
 #* HTTPProxy 127.0.0.1:1234
 }}}

 (note the #* comment), then that's an old value that should be set if the
 user enables that particular option again.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4711#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online