[tor-bugs] #6402 [Tor Sysadmin Team]: set up a code review tool

[Tor Bug Tracker & Wiki]

#6402: set up a code review tool
-------------------------------+--------------------------------------------
 Reporter:  gsathya            |          Owner:     
     Type:  task               |         Status:  new
 Priority:  normal             |      Milestone:     
Component:  Tor Sysadmin Team  |        Version:     
 Keywords:                     |         Parent:     
   Points:                     |   Actualpoints:     
-------------------------------+--------------------------------------------

Comment(by nickm):

 For posterity, let me document my current methodology.

 I take your patch in whatever format it is, and I download it.  If you've
 got a git branch, I do "git remote add yourhandle yourrepo" and then I do
 "git fetch yourhandle".  If it's one or more "git format-patch" files, I
 download it.  If it's a unified diff, I download it grudgingly.  If it's
 something else, I download it extra-grudgingly.

 Then if I downloaded files, I review them with less.  If I downloaded a
 branch, I review it commit-by-commit with "git log -p --stat --reverse
 master..yourhandle/yourbranch". I add -b if you seem to have messed with
 lots of whitespace.  I might also do "git diff
 master...yourhandle/yourbranch" (note the three dots) to get all of your
 changes in the branch in one big diff.  Then I write up comments,
 referencing commit IDs and function names, and put them in trac.

 Note that I always review a local copy, so you can't change the code out
 from under me.

 When I'm done, I do "git checkout master" to get to master, then "git
 merge yourhandle/yourbranch."  Then I try it out for a while, then "git
 push" it.

 For merging stuff not into master but into maint-0.2.3 or something, I
 adjust accordingly.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6402#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online