[tor-bugs] #6397 [Tor Client]: Correctly set bad_since on actually disabled nodes

[Tor Bug Tracker & Wiki]

#6397: Correctly set bad_since on actually disabled nodes
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:  Tor: 0.2.3.17-beta
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 This is Coverity 709599: the check in circuitbuild.c around 4749 that
 does:
 {{{
      if (node->path_bias_disabled && !node->bad_since)
        node->bad_since = time(NULL);
 }}}
 is incorrect: It needs to refer to "e", not "node".

 This could lead to path_bias_disabled nodes not getting disabled, or to
 crashes when using path bias disable thresholds.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6397>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online