[tor-bugs] #5965 [TorBrowserButton]: Flag important sections of Torbutton code for preservation

[Tor Bug Tracker & Wiki]

#5965: Flag important sections of Torbutton code for preservation
---------------------------------+------------------------------------------
    Reporter:  mikeperry         |       Owner:  mikeperry      
        Type:  task              |      Status:  closed         
    Priority:  major             |   Milestone:                 
   Component:  TorBrowserButton  |     Version:                 
  Resolution:  fixed             |    Keywords:  MikePerry201206
      Parent:  #5709             |      Points:  5              
Actualpoints:  5                 |  
---------------------------------+------------------------------------------

Comment(by mikeperry):

 Replying to [comment:5 gk]:
 > Replying to [comment:1 mikeperry]:
 >
 > > Do either of you have any additional suggestions to help make your
 lives easier?
 >
 > I might be a bit late to the party as you already closed the ticket, but
 yes I have some additional suggestions in random order:
 >
 > 1) A nit and maybe not worth fixing: "P0: Toogle mode code. It needs to
 die." -> "P0: It needs to die." as in jshooks.js is no toggle mode related
 code (and torbutton_check_version() and... neither).
 >
 > 2) Throw out FF3 related stuff as nobody is seriously supporting it
 anymore.

 Yeah. I imagine this wisdom will be part of bringing up the Android dev up
 to speed on XPCOM in general, unless they're already an XPCOM wizard, in
 which case it should be obvious.

 > 3) torbutton_test_settings() should die as well and get rather
 implemented as an own test in a test harness.

 This is more for testing that your proxy settings are actually working for
 non-bundled users that manually installed everything.

 > 4) Remove preferences cruft (e.g. setting
 browser.safebrowsing.remoteLookups) and other cruft (contents.rdf).

 Yeah, the TBB prefs.js is our canonical list of pref changes. I've also
 now marked contents.rdf as P0.

 > 5) What about torbutton_util.js and torcookie.js? Priority comments are
 missing in them.

 Ok, added and pushed to origin/master.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5965#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online