[tor-bugs] #6302 [Tor Client]: Use SOCK_ERRNO consistently

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Jul 5 09:13:42 UTC 2012


#6302: Use SOCK_ERRNO consistently
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  minor        |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
 Everywhere that we currently say
 {{{
 #ifdef _WIN32
   frobnicate(WSAENOWOMBATS);
 #else
   frobnicate(ENOWOMBATS);
 #endif
 }}}

 we ought instead to just say:
 {{{
   frobincate(SOCK_ERRNO(ENOWOMBATS));
 }}}
 in order to help get internal #ifdefs out of our functions.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6302>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list