[tor-bugs] #6297 [Tor Client]: SOCKS issues with bitcoin in .2.3.18-rc vs .2.2.37

[Tor Bug Tracker & Wiki]

#6297: SOCKS issues with bitcoin in .2.3.18-rc vs .2.2.37
-------------------------+--------------------------------------------------
 Reporter:  jrmithdobbs  |          Owner:                  
     Type:  defect       |         Status:  new             
 Priority:  normal       |      Milestone:                  
Component:  Tor Client   |        Version:  Tor: 0.2.3.18-rc
 Keywords:               |         Parent:                  
   Points:               |   Actualpoints:                  
-------------------------+--------------------------------------------------

Comment(by jrmithdobbs):

 Ok, I re-read what you were saying and did some checking on how that
 initial handshake packet was being generated. There was an OBO in the code
 sending an extra 0x00 (thanks std:string -> char array conversions) so it
 looks like there's a bug on both ends.

 Will get the bitcoin issue fixed but for really should be throwing the
 general failure or some other error message after the first malformed
 packet not leaving the trailing end of it on the receive buffer and then
 parsing it as the beginning of the next?

 Don't know how high a priority that is really but couldn't this be used
 for some form of abuse with some imagination?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6297#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online