[tor-bugs] #6297 [Tor Client]: SOCKS issues with bitcoin in .2.3.18-rc vs .2.2.37

[Tor Bug Tracker & Wiki]

#6297: SOCKS issues with bitcoin in .2.3.18-rc vs .2.2.37
-------------------------+--------------------------------------------------
 Reporter:  jrmithdobbs  |          Owner:                  
     Type:  defect       |         Status:  new             
 Priority:  normal       |      Milestone:                  
Component:  Tor Client   |        Version:  Tor: 0.2.3.18-rc
 Keywords:               |         Parent:                  
   Points:               |   Actualpoints:                  
-------------------------+--------------------------------------------------

Comment(by nickm):

 I think there's a bug in your socks implementation.  The first part of
 SOCKS5 is for you to send:
 {{{
   05 (one byte, socks version)
   N  (one byte, number of authentications methods you support)
   M  (N bytes, authentication methods, one byte each.)
 }}}

 If I am reading these dumps right, then connect.c is sending [05 02 00 02]
 to say "This is socks 5, I support two authentication methods.  One is 00
 (no auth); one is 02 (password auth, I think)."

 But if I am reading this dump right, your bitcoin tool is saying [05 01 00
 00].  There's an extra byte there that shouldn't be.

 (I could be reading the dump wrong, of course.)

 It looks like 0.2.2.x would accept and discard an extra byte here; 0.2.3.x
 is stricter.

 Can you confirm the analysis above?  Right now it's not looking like a tor
 bug to me.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6297#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online