[tor-bugs] #4991 [Tor Client]: Use standard windows-detection macros

[Tor Bug Tracker & Wiki]

#4991: Use standard windows-detection macros
------------------------------------+---------------------------------------
 Reporter:  nickm                   |          Owner:                  
     Type:  defect                  |         Status:  new             
 Priority:  normal                  |      Milestone:  Tor: unspecified
Component:  Tor Client              |        Version:                  
 Keywords:  easy, windows, cleanup  |         Parent:                  
   Points:                          |   Actualpoints:                  
------------------------------------+---------------------------------------
 In our code, we mostly use  MS_WINDOWS to detect windows; we sometimes use
 WIN32 to detect windows; and we sometimes use _WIN32.

 _WIN32 is standard; WIN32 is obsolete; MS_WINDOWS is our own silliness.
 Let's be consistent and standard and just use WIN32.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4991>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online