[tor-bugs] #4978 [Torctl]: I found a small bug in TorCtl.py, in connection.map_address()

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Sat Jan 28 14:03:35 UTC 2012


#4978: I found a small bug in TorCtl.py, in connection.map_address()
------------------------+---------------------------------------------------
 Reporter:  derpington  |          Owner:                  
     Type:  defect      |         Status:  new             
 Priority:  normal      |      Milestone:                  
Component:  Torctl      |        Version:  Tor: unspecified
 Keywords:  mapaddress  |         Parent:                  
   Points:              |   Actualpoints:                  
------------------------+---------------------------------------------------
 In method connection.map_address() in TorCtl.py, the following line is
 supposed to build the line to be sent to the tor control port in order to
 map a list of adresses:

     m = " ".join([ "%s=%s" for k,v in kvList])

 The string "%s=%s" lacks formatting. Better:

     m = " ".join([ "%s=%s" (k,v) for (k,v) in kvList])

 My first contrib to open source (:
 I hope this is the right place for this

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4978>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list