[tor-bugs] #4955 [- Select a component]: tor-0.2.3.11_alpha: fails to compile when configured --enable-nat-pmp

[Tor Bug Tracker & Wiki]

#4955: tor-0.2.3.11_alpha: fails to compile when configured --enable-nat-pmp
----------------------------------+-----------------------------------------
 Reporter:  blueness              |          Owner:                     
     Type:  defect                |         Status:  new                
 Priority:  normal                |      Milestone:                     
Component:  - Select a component  |        Version:  Tor: 0.2.3.11-alpha
 Keywords:                        |         Parent:                     
   Points:                        |   Actualpoints:                     
----------------------------------+-----------------------------------------
 Version tor-0.2.3.11 introduced a change in src/tools/tor-fw-helper/tor-
 fw-helper-natpmp.c.  A quick diff with 0.2.3.10 shows:

 --- a/tor-fw-helper-natpmp.c    2011-12-15 11:27:07.000000000 -0500
 +++ b/tor-fw-helper-natpmp.c    2012-01-21 22:07:30.000000000 -0500
 @@ -87,7 +87,7 @@

  /** Use select() to wait until we can read on fd. */
  static int
 -wait_until_fd_readable(unsigned int fd, struct timeval *timeout)
 +wait_until_fd_readable(tor_socket_t fd, struct timeval *timeout)
  {
    int r;
    fd_set fds;


 Its pretty obvious that fd should be defined as an unsigned int.
 Reverting and everything compiles fine.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4955>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online